uvashishtha commented on PR #29375: URL: https://github.com/apache/flink/pull/29375#issuecomment-5982445730
> this is not the way reuse should be done please look at existing patterns @snuyanzin Thanks for taking the time to take a look. The same caching mechanism exists for the `REGEXP_PATTERN_CACHE`, `URL_CACHE` in this same file to solve the same problem, I think. A similar problem is solved the same way (`FORMATTER_CACHE`, `DATETIME_FORMATTER_CACHE`, `TIMEZONE_CACHE`) in the `DateTimeUtils` class. Could you reason about why you think this is not right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
