gustavodemorais opened a new pull request, #29372: URL: https://github.com/apache/flink/pull/29372
## What is the purpose of the change A streaming Top-1 ROW_NUMBER that keeps the first row was inferred as insert-only even when ordered by a non-time attribute or multiple columns. Such a query runs as a Rank operator that emits updates, so downstream operators missed retractions and produced wrong results. This PR limits the insert-only inference to deduplications ordered by a single time attribute. Supersedes #28980. ## Brief change log - Add RankUtil.isDeduplicationOnTimeAttribute and reuse it in RankUtil.canConvertToDeduplicate - Use it as the deduplication guard in FlinkChangelogModeInferenceProgram so other Top-1 ranks fall back to the regular Rank branch ## Verifying this change - DeduplicateTest - DeduplicateITCase ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable --- ##### Was generative AI tooling used to co-author this PR? - [x] Yes (please specify the tool below) 2.1.282 (Claude Code) with Opus 5.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
