twalthr opened a new pull request, #29364:
URL: https://github.com/apache/flink/pull/29364

   ## What is the purpose of the change
   
   Follow-up to 
[FLINK-40708](https://issues.apache.org/jira/browse/FLINK-40708) (Support 
`ValueView` in PTFs).
   
   State already flows to a PTF's `onTimer` method symmetrically with `eval` 
(the code generator passes the same state operands to both, and the runtime 
runs the identical kind-based state move logic). This pull request adds a 
semantic test that verifies and locks in that `ValueView` state — together with 
eager value state — is accessible and correctly persisted from both `eval()` 
and `onTimer()`. No production code change is required.
   
   ## Brief change log
   
     - Add `EagerAndValueViewStateTimeFunction`: a PTF with both an eager value 
state entry (a POJO) and a `ValueView<Integer>`, mutating both from `eval()` 
(registering an event-time timer) and from `onTimer()`.
     - Add the `process-eager-and-value-view-state-time` semantic program (on 
`TIMED_SOURCE`, `PARTITION BY name, on_time => DESCRIPTOR(ts)`); the expected 
output proves that mutations done in `onTimer()` to both state kinds persist 
and are visible to the next `eval()` call.
     - Register the program in `ProcessTableFunctionSemanticTests`.
   
   ## Verifying this change
   
   This change is a test addition and is verified by running 
`ProcessTableFunctionSemanticTests` (75 programs, all passing).
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Claude Opus 4.8)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to