[
https://issues.apache.org/jira/browse/FLINK-29967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18121929#comment-18121929
]
Martijn Visser commented on FLINK-29967:
----------------------------------------
Still the case on master, and more visible with ON CONFLICT:
{code}
INSERT INTO sink_with_pk SELECT CAST(b AS INT), CAST(a AS BIGINT), CAST(NOW()
AS STRING) FROM cdc ON CONFLICT DO DEDUPLICATE
{code}
is rejected by {{TRY_RESOLVE}} although the compiled plan passes
{{inputUpsertKey [1]}} to the sink and the materializer matches on it.
SinkUpsertMaterializer, the V2 materializer and
WatermarkCompactingSinkMaterializer all compare by upsert key when there is
one, so visitSink only needs the primary key columns there.
> Optimize determinism requirements from sink node with considering that
> SinkUpsertMaterializer already supports upsertKey
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-29967
> URL: https://issues.apache.org/jira/browse/FLINK-29967
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Planner
> Affects Versions: 2.1.0
> Reporter: lincoln lee
> Priority: Major
> Fix For: 2.4.0
>
>
> This is followup optimization for FLINK-28569
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
