RocMarshal opened a new pull request, #29351: URL: https://github.com/apache/flink/pull/29351
<!-- *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.* *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.* ## What is the purpose of the change This pull request removes deprecated Kubernetes configuration keys that have been superseded by their current names since 2022. The deprecated aliases were introduced by: - Commit: `6cce68dcdc1baf4be2a9e1549983d010644b5ee3` - Commit message: `[FLINK-29372] Add suffix to all options that conflict with YAML` - Author date: `2022-09-28 11:10:05 +02:00` - Commit date: `2022-09-28 11:10:05 +02:00` ## Brief change log ### Changed files - `flink-kubernetes/src/main/java/org/apache/flink/kubernetes/configuration/KubernetesConfigOptions.java` ### Removed deprecated configuration keys | Configuration key | Description | Removed deprecated key | Deprecated key introduction commit | Introduction commit time | |---|---|---|---|---| | `kubernetes.jobmanager.cpu.amount` | The number of CPUs used by the JobManager. | `kubernetes.jobmanager.cpu` | `6cce68dcdc1baf4be2a9e1549983d010644b5ee3` | `2022-09-28 11:10:05 +02:00` | | `kubernetes.taskmanager.cpu.amount` | The number of CPUs used by the TaskManager. By default, the CPU amount is set to the number of slots per TaskManager. | `kubernetes.taskmanager.cpu` | `6cce68dcdc1baf4be2a9e1549983d010644b5ee3` | `2022-09-28 11:10:05 +02:00` | | `kubernetes.container.image.ref` | Image used for Flink containers. The image must use the same Apache Flink and Scala versions as the application. Official images are available from the [Flink Docker Hub repository](https://hub.docker.com/_/flink?tab=tags) and the [Apache Flink Docker Hub repository](https://hub.docker.com/r/apache/flink/tags). | `kubernetes.container.image` | `6cce68dcdc1baf4be2a9e1549983d010644b5ee3` | `2022-09-28 11:10:05 +02:00` | | `kubernetes.pod-template-file.default` | Local pod template file used to initialize JobManager and TaskManager pods. The main container must be named `flink-main-container`. JobManager- and TaskManager-specific pod template options can override this value. | `kubernetes.pod-template-file` | `6cce68dcdc1baf4be2a9e1549983d010644b5ee3` | `2022-09-28 11:10:05 +02:00` | ## Verifying this change This change is a configuration cleanup that removes deprecated aliases. It does not add or modify test logic. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes (`KubernetesConfigOptions` is annotated with `@PublicEvolving`) - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes (Kubernetes configuration) - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
