RocMarshal opened a new pull request, #29350:
URL: https://github.com/apache/flink/pull/29350
<!--
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
contribution in the best possible way, please go through the checklist below,
which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a
hassle. In order to uphold a high standard of quality for code contributions,
while at the same time managing a large number of contributions, we need
contributors to prepare the contributions well, and give reviewers enough
contextual information for the review. Please also understand that
contributions that do not follow this guide will take longer to review and thus
typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are
made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the
pull request", where *FLINK-XXXX* should be replaced by the actual issue
number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following
this pattern: `[hotfix] [docs] Fix typo in event time introduction` or
`[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes. You can set up Azure Pipelines CI to do that following [this
guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
(including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
[FLINK-40815][configuration] Remove the deprecated configuration keys from
the flink-dstl-dfs module.
## Brief change log
### Changed files
-
`flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogOptions.java`
### Introduction commit
All deprecated keys removed by this commit were introduced by the same
commit:
- Commit: `e7e973e212d0ca04855af3036fc5b73888b8e0e5`
- Commit message: `[FLINK-34458][checkpointing] Rename options for
Generalized incremental checkpoints (changelog) (#24324)`
- Author date: `2024-02-18 18:38:48 +08:00`
- Commit date: `2024-02-22 14:03:41 +08:00`
### Removed deprecated keys
| Configuration key | Description | Removed deprecated key | Deprecated key
introduction commit | Introduction commit time |
|---|---|---|---|---|
| `state.changelog.dstl.dfs.base-path` | Base path to store changelog files.
| `dstl.dfs.base-path` | `e7e973e212d0ca04855af3036fc5b73888b8e0e5` |
`2024-02-22 14:03:41 +08:00` |
| `state.changelog.dstl.dfs.compression.enabled` | Whether to enable
compression when serializing changelog. | `dstl.dfs.compression.enabled` |
`e7e973e212d0ca04855af3036fc5b73888b8e0e5` | `2024-02-22 14:03:41 +08:00` |
| `state.changelog.dstl.dfs.preemptive-persist-threshold` | Size threshold
for state changes of a single operator beyond which they are persisted
pre-emptively without waiting for a checkpoint. Improves checkpointing time by
allowing quasi-continuous uploading of state changes, as opposed to uploading
all accumulated changes on checkpoint. |
`dstl.dfs.preemptive-persist-threshold` |
`e7e973e212d0ca04855af3036fc5b73888b8e0e5` | `2024-02-22 14:03:41 +08:00` |
| `state.changelog.dstl.dfs.batch.persist-delay` | Delay before persisting
changelog after receiving a persist request on checkpoint. Minimizes the number
of files and requests if multiple operators, backends, or subtasks use the same
store. Correspondingly increases checkpoint time in the asynchronous phase. |
`dstl.dfs.batch.persist-delay` | `e7e973e212d0ca04855af3036fc5b73888b8e0e5` |
`2024-02-22 14:03:41 +08:00` |
| `state.changelog.dstl.dfs.batch.persist-size-threshold` | Size threshold
for state changes requested to be persisted but waiting for
`state.changelog.dstl.dfs.batch.persist-delay` across all operators. Once
reached, accumulated changes are persisted immediately. Unlike
`state.changelog.dstl.dfs.preemptive-persist-threshold`, this happens after the
checkpoint and can cover changes from multiple operators. Must not exceed the
in-flight data limit. | `dstl.dfs.batch.persist-size-threshold` |
`e7e973e212d0ca04855af3036fc5b73888b8e0e5` | `2024-02-22 14:03:41 +08:00` |
| `state.changelog.dstl.dfs.upload.buffer-size` | Buffer size used when
uploading change sets. | `dstl.dfs.upload.buffer-size` |
`e7e973e212d0ca04855af3036fc5b73888b8e0e5` | `2024-02-22 14:03:41 +08:00` |
| `state.changelog.dstl.dfs.upload.num-threads` | Number of threads to use
for upload. | `dstl.dfs.upload.num-threads` |
`e7e973e212d0ca04855af3036fc5b73888b8e0e5` | `2024-02-22 14:03:41 +08:00` |
| `state.changelog.dstl.dfs.discard.num-threads` | Number of threads used to
discard changelog, such as pre-emptively uploaded unused state. |
`dstl.dfs.discard.num-threads` | `e7e973e212d0ca04855af3036fc5b73888b8e0e5` |
`2024-02-22 14:03:41 +08:00` |
| `state.changelog.dstl.dfs.upload.max-in-flight` | Maximum amount of data
allowed to be in flight. Reaching the limit back-pressures the task:
snapshotting blocks, and normal processing blocks when
`state.changelog.dstl.dfs.preemptive-persist-threshold` is configured and
reached. The limit applies to the total in-flight changes when multiple
operators or backends use the same changelog storage, and must be greater than
or equal to `state.changelog.dstl.dfs.batch.persist-size-threshold`. |
`dstl.dfs.upload.max-in-flight` | `e7e973e212d0ca04855af3036fc5b73888b8e0e5` |
`2024-02-22 14:03:41 +08:00` |
| `state.changelog.dstl.dfs.upload.retry-policy` | Retry policy for failed
uploads, particularly timed-out uploads. Valid values are `none` and `fixed`. |
`dstl.dfs.upload.retry-policy` | `e7e973e212d0ca04855af3036fc5b73888b8e0e5` |
`2024-02-22 14:03:41 +08:00` |
| `state.changelog.dstl.dfs.upload.timeout` | Time threshold beyond which an
upload is considered timed out. If a new attempt starts but the earlier upload
succeeds first, the earlier result is used. This can improve upload times when
tail latencies are high. It applies only when
`state.changelog.dstl.dfs.upload.retry-policy` is `fixed`. The timeout
multiplied by the maximum attempts should be less than
`execution.checkpointing.timeout`. | `dstl.dfs.upload.timeout` |
`e7e973e212d0ca04855af3036fc5b73888b8e0e5` | `2024-02-22 14:03:41 +08:00` |
| `state.changelog.dstl.dfs.upload.max-attempts` | Maximum number of
attempts, including the initial attempt, for a particular upload. Applies only
when `state.changelog.dstl.dfs.upload.retry-policy` is `fixed`. |
`dstl.dfs.upload.max-attempts` | `e7e973e212d0ca04855af3036fc5b73888b8e0e5` |
`2024-02-22 14:03:41 +08:00` |
| `state.changelog.dstl.dfs.upload.next-attempt-delay` | Delay before the
next attempt when the failure was not caused by a timeout. |
`dstl.dfs.upload.next-attempt-delay` |
`e7e973e212d0ca04855af3036fc5b73888b8e0e5` | `2024-02-22 14:03:41 +08:00` |
| `state.changelog.dstl.dfs.download.local-cache.idle-timeout-ms` | Maximum
idle time for distributed changelog cache files, after which the cache files
are deleted. | `dstl.dfs.download.local-cache.idle-timeout-ms` |
`e7e973e212d0ca04855af3036fc5b73888b8e0e5` | `2024-02-22 14:03:41 +08:00` |
## Verifying this change
Please make sure both new and modified tests in this PR follow [the
conventions for tests defined in our code quality
guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#7-testing).
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't
know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change the checkbox below to `[X]` and replace the placeholder in the
"Generated-by"
line with the tool name and version. Otherwise remove the "Generated-by"
line.
See the ASF Generative Tooling Guidance for details:
https://www.apache.org/legal/generative-tooling.html
You are responsible for the quality and correctness of every change in this
PR
regardless of the tooling used. Low-effort AI-generated PRs will be closed.
See
AGENTS.md for the full guidance.
-->
- [ ] Yes (please specify the tool below)
Generated-by: [Tool Name and Version]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
