laughingman7743 commented on PR #156: URL: https://github.com/apache/flink-connector-jdbc/pull/156#issuecomment-5932783079
@MartijnVisser I've rebased onto the latest main to resolve the conflicts. The history is still the same 5 commits. Following FLINK-40781, the Spanner module now has its own ArchUnit tests: - Added `ProductionCodeArchitectureTest`, `TestCodeArchitectureTest` and `archunit.properties`, the same as in the other modules. The store is frozen on Flink 2.1.3 with JDK 17. - Fixed the violations where possible. `SpannerCatalog.getSpannerOptions` no longer has `@VisibleForTesting`, since production code calls it. `SpannerDialectConverter` now gets the precision from `TimestampType`/`LocalZonedTimestampType` instead of the internal `LogicalTypeChecks.getPrecision`. - Only two violations remain frozen, and both follow existing patterns: the `@VisibleForTesting` catalog constructor (as in `PostgresCatalog` and `MySqlCatalog`) and `LogicalTypeUtils.toInternalConversionClass` in the array converter (as in `PostgresDialectConverter`). - In the core store, I updated the existing entry for the `AbstractJdbcCatalog` → `AbstractCatalog` constructor call to point to the new constructor that takes the default database resolver. It is the same violation as before, now in the new constructor. The core and Spanner tests, including ArchUnit, pass locally against both Flink 2.1.3 and 2.3.0. Could you please approve the CI run again? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
