Savonitar opened a new pull request, #330: URL: https://github.com/apache/flink-connector-kafka/pull/330
## What is the purpose of the change Fix [FLINK-40847](https://issues.apache.org/jira/browse/FLINK-40847): Kafka table sinks with different transaction naming strategies currently compare equal, so factory tests cannot detect an incorrectly translated strategy. ## Brief change log - Include `transactionNamingStrategy` in `KafkaDynamicSink.equals()` and `hashCode()`. - Extend both Kafka and upsert Kafka factory tests to distinguish strategies and verify equality and hash-code consistency after copying a sink. ## Verifying this change - Both strategy regression tests failed against the original implementation. - All 68 tests in `KafkaDynamicTableFactoryTest` and `UpsertKafkaDynamicTableFactoryTest` passed with the fix. - Checkstyle and Spotless checks passed. - `./mvnw -o clean verify` passed for all eight reactor modules on Java 17 in a clean checkout of the PR commit. ## Does this pull request potentially affect one of the following parts: - Dependencies: no - Public API, Table options, or PyFlink wrappers: no - Checkpointed state, serializers, or exactly-once delivery: no - Per-record code paths: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable - If the docs changed, are both `docs/content` and `docs/content.zh` updated? not applicable --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes Generated-by: Codex 0.158.0-alpha.2.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
