fmorillo7694 commented on PR #236: URL: https://github.com/apache/flink-connector-aws/pull/236#issuecomment-5885230841
Two small follow-up commits, applying the review lenses from #206 to this PR before they get raised here: * f296ad9 (docs): each format page now has a Limitations section derived from the converters' actual behaviour. Until now none of the three pages said which Flink SQL types are rejected, although `json-glue` and `protobuf-glue` deliberately throw `UnsupportedOperationException` for unsupported types instead of coercing them to `string` (protobuf: scalar fields only; json: `ARRAY`/`MAP`/`ROW` supported, `MAP` keys must be strings), and all three have lossy representations (precision, scale and length are enforced on the Flink side only). Mirrored in `content.zh`. * 914bb5f (tests): the protobuf module declared `flink-architecture-tests-test` but had no `TestCodeArchitectureTest`, `archunit.properties` or violation store, so the architecture rules never ran against it. Wired like the avro module; 27/27 unit tests including the architecture rules. Also re-checked the other lenses here: every option key used in the doc examples resolves to a declared factory option (the e2e ITCases execute the same key set against the real factories), and the protobuf keyword regexes are correctly case-sensitive since `message` is case-sensitive in proto syntax. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
