gustavodemorais commented on code in PR #29296:
URL: https://github.com/apache/flink/pull/29296#discussion_r4121074784
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/StreamingJoinOperator.java:
##########
@@ -215,6 +217,8 @@ protected void processElement(
input.setRowKind(RowKind.INSERT); // erase RowKind for later state
updating
if (isAccumulateMsg) { // record is accumulate
+ final boolean isAdditionalMatch =
+ isAdditionalMatch(input, inputSideStateView, inputIsLeft);
Review Comment:
My goal was to fix each case individually. If I can keep the minibatch fix
small, I can add it as a second commit here. I'll check that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
