seungjoo-choi-bucketplace commented on PR #29168: URL: https://github.com/apache/flink/pull/29168#issuecomment-5854820755
Hi @Zakelly, @fredia and @Myasuka, could you take a look at this when you have a chance? It fixes a connection leak in the ForSt file cache: `CachedDataInputStream.close()` closes only the cached local stream and never the wrapped remote stream that `FileCacheEntry#open` handed it, so each close leaks one S3A pool connection until the pool is exhausted and reads fail with `Timeout waiting for connection from pool`. The fix also closes the remote stream, without changing the cached-stream lifecycle. It's small and self-contained, has unit test coverage (`CachedDataInputStreamTest`), and CI is green. Given your work on ForSt's file cache and stream lifecycle, I'd really appreciate your review. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
