seungjoo-choi-bucketplace commented on PR #29169: URL: https://github.com/apache/flink/pull/29169#issuecomment-5854399973
Thanks for the review! Added in 4eb8efb — `testClosedStreamIsUnregisteredWhenCachedCloseThrows` covers exactly that: it builds a `CACHED_OPEN` wrapper whose cached stream's `close()` throws, then asserts the wrapper is no longer in `FileCacheEntry#openedStreams` after the `IOException` — i.e. the unregister-before-`closeCachedStream()` ordering holds even when the cached close fails. Since `open()` only ever yields a real, non-throwing cached stream, the CACHED_OPEN wrapper is constructed directly with a throwing stream to reach the failing-close path. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
