snuyanzin opened a new pull request, #29301:
URL: https://github.com/apache/flink/pull/29301
## What is the purpose of the change
`FineGrainedSlotManager` runs its resource-requirement checks on a short
timer: instead of reacting immediately.
When the slot manager is stopped (`suspend()`/`close()`), it cancels its
other timers (`clusterReconciliationCheck`, `metricsUpdateFuture`) but cannot
cancel these delayed checks since there's no handle to cancel. So a delayed
check that was already scheduled stays pending and fires after the slot manager
has been shut down.
When that late task runs, it goes through `checkResourceRequirements()` =>
`allocateSlotsAccordingTo()` => `DefaultSlotStatusSyncer.allocateSlot()`
The problem is that executor is already shutting down, as a result it throws
`RejectedExecutionException`
(Test with repro is included)
The PR makes pending tasks also being canceled for such case.
## Brief change log
`FineGrainedSlotManager.java`
`FineGrainedSlotManagerTest.java`
## Verifying this change
Test with repro is included
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency):( no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): ( no )
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: ( no )
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable )
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change the checkbox below to `[X]` and replace the placeholder in the
"Generated-by"
line with the tool name and version. Otherwise remove the "Generated-by"
line.
See the ASF Generative Tooling Guidance for details:
https://www.apache.org/legal/generative-tooling.html
You are responsible for the quality and correctness of every change in this
PR
regardless of the tooling used. Low-effort AI-generated PRs will be closed.
See
AGENTS.md for the full guidance.
-->
- [ ] Yes (please specify the tool below)
Generated-by: [Tool Name and Version]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
