[ 
https://issues.apache.org/jira/browse/FLINK-5494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849573#comment-15849573
 ] 

ASF GitHub Bot commented on FLINK-5494:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3236#discussion_r99062197
  
    --- Diff: docs/setup/mesos.md ---
    @@ -107,29 +107,58 @@ Unvierse. Please use the following workaround in the 
meantime:
     
     ## Mesos without DC/OS
     
    -Let's take a look at how to setup Flink on Mesos without DC/OS. 
    +You can also run Mesos without DC/OS.
     
    -### Prerequisites
    +### Installing Mesos
     
    -Please follow the
    -[instructions on how to setup Mesos on the official 
website](http://mesos.apache.org/documentation/latest/). 
    +Please follow the [instructions on how to setup Mesos on the official 
website](http://mesos.apache.org/documentation/latest/getting-started/).
    +
    +After installation you have to configure the set of master and agent nodes 
by creating the files `MESOS_HOME/etc/mesos/masters` and 
`MESOS_HOME/etc/mesos/slaves`.
    +These files contain in each row a single hostname on which the respective 
component will be started (assuming SSH access to these nodes).
    +
    +Next you have to create `MESOS_HOME/etc/mesos/mesos-master-env.sh` or use 
the template found in the same directory.
    +In this file, you have to define
    +
    +    export MESOS_work_dir=WORK_DIRECTORY
    +
    +and it is recommended to uncommment
    +
    +    export MESOS_log_dir=LOGGING_DIRECTORY
    +
    +
    +In order to configure the Mesos agents, you have to create 
`MESOS_HOME/etc/mesos/mesos-agent-env.sh` or use the template found in the same 
directory.
    +You have to configure
    +
    +    export MESOS_master=MASTER_HOSTNAME:MASTER_PORT
    +
    +and uncomment
    +
    +    export MESOS_log_dir=LOGGING_DIRECTORY
    +    export MESOS_work_dir=WORK_DIRECTORY
    +
    +#### Mesos Library
    +
    +In order to run Java applications with Mesos you have to export 
`MESOS_NATIVE_JAVA_LIBRARY=MESOS_HOME/lib/libmesos.so`.
    --- End diff --
    
    On Mac, the native library name seems to be `libmesos.dylib`. Might be good 
to inform in the docs what OS the instructions is assuming, or just add a small 
comment about MacOS here.


> Improve Mesos documentation
> ---------------------------
>
>                 Key: FLINK-5494
>                 URL: https://issues.apache.org/jira/browse/FLINK-5494
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Mesos
>    Affects Versions: 1.2.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>             Fix For: 1.2.0
>
>
> Flink's Mesos documentation could benefit from more details how to set things 
> up and which parameters to use.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to