MartijnVisser opened a new pull request, #239: URL: https://github.com/apache/flink-connector-jdbc/pull/239
Backport of https://github.com/apache/flink-connector-jdbc/pull/235 (f9b8e8c) to `v3.4`. The cherry-pick conflicted on imports only, `v3.4` has no lineage imports in `JdbcSource`; the change itself applies as is. One addition on top of the cherry-pick: `v3.4` still carries the deprecated `org.apache.flink.connector.jdbc.source.JdbcSource`, which builds the same split readers from the same shared provider. Since `JdbcSourceSplitReader.close()` now closes the provider as well, leaving it alone would have made the deprecated source worse than it is today, so it copies the provider too. It has no source test of its own on this branch. Verified on this branch: `mvn verify` on `flink-connector-jdbc-core` is green, 223 unit and 34 integration tests, and on `flink-connector-jdbc` 61 tests with 1 skipped. `JdbcSourceTest#testSplitReadersDoNotShareAConnection` is red with the copy removed, `java.sql.SQLException` on the running reader's fetch after the finished reader closed. The stress numbers on `DerbyDynamicTableSourceITCase#testLimit` are in the source PR; they were not repeated here. --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes (please specify the tool below) Generated-by: Claude Code (Opus 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
