snuyanzin commented on code in PR #232:
URL:
https://github.com/apache/flink-connector-jdbc/pull/232#discussion_r4060834399
##########
flink-connector-jdbc-mysql/src/test/java/org/apache/flink/connector/jdbc/mysql/database/catalog/MySqlCatalogTestBase.java:
##########
@@ -513,12 +514,14 @@ void testSelectToInsert() throws Exception {
@Test
void testGroupByInsert() throws Exception {
// Changes primary key for the next record.
+ String onConflict = isFlink558Enabled() ? " ON CONFLICT DO
DEDUPLICATE" : "";
Review Comment:
```suggestion
String onConflict = isFlip558Enabled() ? " ON CONFLICT DO
DEDUPLICATE" : "";
```
based on https://issues.apache.org/jira/browse/FLINK-38926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
