csurong commented on code in PR #29245:
URL: https://github.com/apache/flink/pull/29245#discussion_r4059101358


##########
flink-python/pyflink/dataframe/dataframe.py:
##########
@@ -1369,6 +1369,125 @@ def columns(self) -> List[str]:
 
     # ======================== I/O ========================
 
+    @PublicEvolving()
+    def write_parquet(
+        self,
+        path: str,
+        *,
+        mode: str = "overwrite",
+        compression: str = "SNAPPY",
+        rolling_policy_file_size: str = "128mb",
+        rolling_policy_rollover_interval: str = "30min",
+        rolling_policy_check_interval: Optional[str] = None,
+        partition_commit_trigger: str = "process-time",

Review Comment:
   Thanks for catching this. Added `partition_by` to both readers and writers 
in b104961a064, with the partition keys passed to 
`TableDescriptor.partitioned_by(...)`. I also added partitioned 
round-trip/overwrite tests and streaming partition-commit tests, including a 
non-UTC case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to