CodeTrainerMan commented on issue #1108: URL: https://github.com/apache/flink-agents/issues/1108#issuecomment-5752873735
Hi @emecii and @wenjin272, This one has been quiet since Sep 14 and I don't see a PR linked to it, so I'd like to check whether @emecii is still planning to pick it up. If it is free, I would like to take it. My plan follows the direction @wenjin272 already endorsed: - `SkillManager.close()` attempts every distinct repository; - the first `close()` failure is rethrown after the loop, matching the Java `SkillManager.closeRepos()` contract from #987 and the existing Python `ResourceCache.close()` pattern; - later failures are logged consistently with `ResourceCache.close()`; - focused tests using test repositories whose `close()` raises, including one that proves the remaining repositories are still closed. I will wait for a reply before branching, so we do not duplicate work. If @emecii already has something in flight, no problem, I will step aside. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
