MartijnVisser opened a new pull request, #225:
URL: https://github.com/apache/flink-connector-jdbc/pull/225

   ## What is the purpose of the change
   
   `JdbcTablePlanTest` errors in four of its ten cases on Flink 2.2:
   
   ```
   java.lang.IllegalArgumentException: TestCase 'testFilterPushdown' is out of 
order in the reference file: .../JdbcTablePlanTest.xml
   ```
   
   Flink 2.2's `DiffRepository` (FLINK-38609) requires the `<TestCase>` 
elements of a plan reference file to be in alphabetical order. 
`JdbcTablePlanTest.xml` is in insertion order, so the four cases that follow a 
lexicographically greater name fail: `testFilterPushdown`, `testLookupJoin`, 
`testLookupJoinWith2ANDsAndORFilter` and `testLookupJoinWithANDAndORFilter`. 
The weekly has been red on this since 2026-07-26; run 35518052782 shows it on 
both the `main`/2.2-SNAPSHOT and `v4.1`/2.2.0 legs.
   
   ## Brief change log
   
   - Reorder the ten `<TestCase>` blocks of `JdbcTablePlanTest.xml` 
alphabetically. Pure block move, no body changes.
   
   ## Verifying this change
   
   This change is a test reference-file reorder and is covered by 
`JdbcTablePlanTest` itself.
   
   `mvn -pl flink-connector-jdbc-core test -Dtest=JdbcTablePlanTest 
-Dflink.version=2.2.0` on `main` at 73a3f34 gives the same four errors as CI. 
With this change it passes 10/10 on Flink 2.0.1, 2.1.1, 2.2.0 and 2.2.1, and 
`spotless:check` and `checkstyle:check` pass. The file is byte-identical on 
`v4.1`, so the commit cherry-picks cleanly there.
   
   ## Does this pull request potentially affect one of the following parts:
   
   - Dependencies (does it add or upgrade a dependency): no
   - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
   - The serializers: no
   - The runtime per-record code paths (performance sensitive): no
   - Anything that affects deployment or recovery: no
   
   ## Documentation
   
   - Does this pull request introduce a new feature? no
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Fable 5.1)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to