MartijnVisser opened a new pull request, #29222:
URL: https://github.com/apache/flink/pull/29222
## What is the purpose of the change
* `s3_start` missed the `docker run` exit code and never waited for the
container, so a failed image
pull left `S3_ENDPOINT` as the bare string `http://` and 'Run kubernetes
Materialized Table test'
failed with a null session handle.
## Brief change log
* `s3_start` keeps the `docker run` exit code, retries three times, aborts
if the container does not
come up, and rejects an endpoint without a port binding
* New `wait_for_container_running` in `common.sh`, used by `s3_start` and
`aws_cli_start`
* `test_kubernetes_materialized_table.sh` rejects an empty or `null` session
handle
## Verifying this change
This change added tests and can be verified as follows:
* `s3_start` against a `docker` stub reproducing the failed pulls of azure
79037 and 79076: 12 of 12
red on 2440f65c9fd, 4 of 4 green after
* against real docker: the happy path serves `/healthz`, a missing image tag
aborts
* the e2e test itself needs minikube with `--vm-driver=none` and does not
run on macOS
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
