gaborgsomogyi commented on code in PR #19615:
URL: https://github.com/apache/flink/pull/19615#discussion_r4025464880
##########
flink-runtime/src/test/java/org/apache/flink/runtime/util/SerializedThrowableTest.java:
##########
@@ -150,9 +153,11 @@ public void testCopyPreservesCause() {
assertNotNull(serialized.getCause());
SerializedThrowable copy = new SerializedThrowable(serialized);
- assertEquals("parent message", copy.getMessage());
+ assertEquals(
+ "org.apache.flink.util.SerializedThrowable:
java.lang.Exception: parent message",
+ copy.getMessage());
Review Comment:
@WencongLiu @xintongsong
I think this silently introduced a behavior change which can go through
until the operator when we use `SerializedThrowable`. I've 2 problems with it:
1. Java conventions is that `getMessage()` contains the message only
2. copy consctructor must not change object's observable state
(`getMessage()`, `getCause()`, `getOriginalErrorClassName()`, etc.).
Can you guys elaborate what was the plan?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
