snuyanzin commented on code in PR #29200: URL: https://github.com/apache/flink/pull/29200#discussion_r4021043460
########## flink-table/flink-table-planner/src/test/resources/explain/stream/join/lookup/testAggAndAllConstantLookupKeyWithTryResolveMode.out: ########## @@ -12,7 +12,7 @@ LogicalSink(table=[default_catalog.default_database.Sink1], fields=[a, name, age == Optimized Physical Plan == Sink(table=[default_catalog.default_database.Sink1], fields=[a, name, age]) -+- LookupJoin(table=[default_catalog.default_database.LookupTable], joinType=[LeftOuterJoin], lookup=[id=100], where=[=(id, 100)], select=[a, name, age], upsertMaterialize=[true]) ++- LookupJoin(table=[default_catalog.default_database.LookupTable, filter=[]], joinType=[LeftOuterJoin], lookup=[id=100], where=[=(id, 100)], select=[a, name, age], upsertMaterialize=[true]) Review Comment: can we do not put empty collections here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
