chrislusf commented on code in PR #28560:
URL: https://github.com/apache/flink/pull/28560#discussion_r4020684688
##########
flink-end-to-end-tests/test-scripts/common_s3_seaweedfs.sh:
##########
@@ -47,19 +47,20 @@ function s3_start {
export SEAWEEDFS_CONTAINER_ID=$(docker run -d \
-P \
-e "AWS_ACCESS_KEY_ID=$AWS_ACCESS_KEY_ID" -e
"AWS_SECRET_ACCESS_KEY=$AWS_SECRET_ACCESS_KEY" \
- chrislusf/seaweedfs:4.34 \
- server \
- -s3 \
+ chrislusf/seaweedfs:4.38 \
+ mini \
-s3.port=8333 \
- -dir=/data)
+ -dir=/data \
+ -bucket="$IT_CASE_S3_BUCKET")
while [[ "$(docker inspect -f {{.State.Running}} "$SEAWEEDFS_CONTAINER_ID")"
-ne "true" ]]; do
sleep 0.1
done
export S3_ENDPOINT="http://$(docker port "$SEAWEEDFS_CONTAINER_ID" 8333 |
grep -F '0.0.0.0' | sed s'/0\.0\.0\.0/localhost/')"
echo "Started seaweedfs @ $S3_ENDPOINT"
on_exit s3_stop
- while [[ "$(curl -s -o /dev/null -w '%{http_code}' "$S3_ENDPOINT/healthz")"
!= "200" ]]; do
+ # mini pre-creates the bucket and reports readiness only once all components
are up.
+ while ! docker logs "$SEAWEEDFS_CONTAINER_ID" 2>&1 | grep -q "All enabled
components are running and ready to use"; do
Review Comment:
addressed in
https://github.com/apache/flink/pull/28560/commits/1ca4ada2b66b79b4db0dae69e42ce2081ee93813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
