MartijnVisser opened a new pull request, #29198:
URL: https://github.com/apache/flink/pull/29198
## What is the purpose of the change
Backport of 9c1015353f8 (#28997) to release-2.2, which the Jira has as
fixVersion 2.2.2. The branch still ends the UC rescale jobs with
`jobClient.cancel().get()`, which only acknowledges that cancellation was
initiated, so JUnit can start deleting the `@TempDir` checkpoint directory
while the source subtasks are still writing their async snapshot into it.
## Brief change log
* `CommonTestUtils.terminateJob` waits for the CANCELED terminal state
after `cancel()`
* The two UC rescale ITCases go through it instead of `cancel().get()`
* `SinkTestSuiteBase` and `SourceTestSuiteBase` drop their local `killJob`
helpers, which did the same wait
## Verifying this change
This change is already covered by existing tests, such as
`UnalignedCheckpointRescaleWithMixedExchangesITCase` and
`UnalignedCheckpointRescaleSameUpstreamITCase`.
* The commit conflicted in
`UnalignedCheckpointRescaleWithMixedExchangesITCase` because master also
carries the third rescale step from FLINK-39140, which is not on this branch.
Only the two cancel sites that exist here were converted, nothing from
FLINK-39140 was pulled in
* Both ITCases pass on this branch (7 tests, and the run repeated both
suites a second time, all green)
* The race itself does not reproduce on macOS, so this run only shows the
tests still pass. The nightly occurrences logged on the Jira so far are on
release-1.20
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no, test code only
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
