cjohnson-confluent commented on code in PR #29063: URL: https://github.com/apache/flink/pull/29063#discussion_r4011906777
########## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/functions/SqlJsonUtilsConversionTest.java: ########## Review Comment: Agreed, pushed a dedup commit. Removed ~40 IT cases that were re-exercising `convertJsonScalar`/`convertJsonArray` logic already covered by unit tests (DECIMAL boundaries, precision loss, whitespace, boolean conversions, extra ON ERROR permutations, redundant array type variants). Added 4 unit tests for coverage that was previously IT-only. Kept IT cases for things unit tests can't cover: boxed-to-primitive CAST, boxed reference equality, string-literal DEFAULT compile regression, type validation errors, missing path ON EMPTY routing, nested array rejection, and one happy-path per RETURNING type. IT count: 976 to 890. Unit tests: 87 to 93. All passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
