MartijnVisser opened a new pull request, #29171:
URL: https://github.com/apache/flink/pull/29171
## What is the purpose of the change
Two metric group variables that differ only in characters we replace become
one label name. Prometheus then rejects the whole scrape, so one such metric
costs us every other metric of that process.
## Brief change log
* Stop reporting a metric whose variables collide into one label name
* Warn once per colliding label name
## Verifying this change
This change added tests and can be verified as follows:
* `metricIsNotReportedWhenTwoVariablesSanitiseToTheSameLabelName` fails
before this change and passes after it
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: yes, `AbstractPrometheusReporter` is `@PublicEvolving`. No
signature changes, but a colliding metric that used to be reported no longer is
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
