MartijnVisser opened a new pull request, #29172:
URL: https://github.com/apache/flink/pull/29172
## What is the purpose of the change
We store a collector under the metric name alone, so a metric whose
variables differ from the first of that name reuses it and its values go out
under the wrong label names. Depends on #29171.
## Brief change log
* Stop reporting a metric whose label names do not match its collector
* Copy the variables in iteration order in the removal test, since values
bind by position
## Verifying this change
This change added tests and can be verified as follows:
*
`metricIsNotReportedWhenItsVariablesDifferFromAnEarlierMetricOfTheSameName`
fails before this change and passes after it
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: yes, `AbstractPrometheusReporter` is `@PublicEvolving`. No
signature changes, but a mismatching metric that used to be reported under the
wrong label names no longer is
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
