gyfora commented on code in PR #1205:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1205#discussion_r4002779083
##########
examples/basic-checkpoint-ha.yaml:
##########
@@ -31,6 +31,11 @@ spec:
high-availability:
type: kubernetes
storageDir: file:///flink-data/ha
+ # Keep the below property uncommented when running against
StateMachineExample job on
+ # Flink 2.0 to 2.3 because that job enables async state which does not
support
+ # canonical savepoints. This is fixed by FLINK-39061 in Flink 2.4 and
later, so the
+ # property can be removed when running against that job on Flink 2.4 and
later.
+ # This problem is not in place for Flink 1.20 or lower.
Review Comment:
I think this comment is unnecessary and too verbose
##########
examples/snapshot/savepoint-job-full-spec.yaml:
##########
@@ -28,5 +28,10 @@ spec:
savepoint:
alreadyExists: false
disposeOnDelete: true
- formatType: CANONICAL
+ # Keep the below property uncommented when running against
StateMachineExample job on
+ # Flink 2.0 to 2.3 because that job enables async state which does not
support
+ # canonical savepoints. This is fixed by FLINK-39061 in Flink 2.4 and
later, so the
+ # property can be removed when running against that job on Flink 2.4 and
later.
+ # This problem is not in place for Flink 1.20 or lower.
Review Comment:
I think this comment is unnecessary and too verbose
##########
examples/snapshot/savepoint-job-defaults.yaml:
##########
@@ -25,4 +25,10 @@ spec:
jobReference:
kind: FlinkDeployment
name: example-deployment
- savepoint: {} # This will use the savepoint path configured in the job
config.
+ savepoint:
+ # Keep the below property uncommented when running against
StateMachineExample job on
+ # Flink 2.0 to 2.3 because that job enables async state which does not
support
+ # canonical savepoints. This is fixed by FLINK-39061 in Flink 2.4 and
later, so the
+ # property can be removed when running against that job on Flink 2.4 and
later.
+ # This problem is not in place for Flink 1.20 or lower.
Review Comment:
I think this comment is unnecessary and too verbose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
