davidradl commented on code in PR #29163:
URL: https://github.com/apache/flink/pull/29163#discussion_r3990499752
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/LogicalTypeCastsTest.java:
##########
@@ -386,11 +387,11 @@ private static Stream<Arguments> testData() {
Arguments.of(new BinaryType(10), new UuidType(), false, false),
// UUID identity cast is implicit
Arguments.of(new UuidType(), new UuidType(), true, true),
- // numeric and VARIANT are not castable to or from UUID
+ // numeric is not castable to or from UUID
Arguments.of(new UuidType(), new IntType(), false, false),
Arguments.of(new IntType(), new UuidType(), false, false),
- Arguments.of(new UuidType(), new VariantType(), false, false),
- Arguments.of(new VariantType(), new UuidType(), false, false));
+ // a UUID does not cast to VARIANT
+ Arguments.of(new UuidType(), new VariantType(), false, false));
Review Comment:
I assume casting to its existing type is safe - does it warrant a test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
