MartijnVisser opened a new pull request, #319: URL: https://github.com/apache/flink-connector-kafka/pull/319
## What is the purpose of the change FLINK-40459 moved Flink and flink-shaded from Maven 3.8.6 to 3.9.16. This does the same for the Kafka connector. The shared connector CI derives the Maven version it installs from `distributionUrl` in `.mvn/wrapper/maven-wrapper.properties`, so bumping the wrapper moves CI along with local builds. ## Brief change log - `.mvn/wrapper/maven-wrapper.properties`: Maven 3.9.16, with the checksum published on Maven Central. The wrapper scripts are already at 3.3.4 and are unchanged. - `README.md`: recommend 3.9.16. - `pom.xml`: pin the exact version in the `release` profile, mirroring what flink-shaded does. The profile repeats the parent's activation because `flink-connector-parent` activates its `release` profile on the property rather than on `-P`; without that, a `-Drelease` build silently keeps the inherited `[3.2.5,)`. ## Verifying this change - `./mvnw --version` reports 3.9.16, which also verifies the new checksum. - `./mvnw clean verify` passes on JDK 11, 17 and 21; `flink-connector-kafka` unit tests pass (436 tests). - `./mvnw help:effective-pom -Drelease` shows `[3.9.16]` in the executing enforcer block and retains the parent's `requireJavaVersion`; a plain build still shows `[3.1.1,)`. - Red/green on the pin: with Maven 3.8.6, `mvn -Drelease validate` now fails with `Detected Maven Version: 3.8.6 is not in the allowed range [3.9.16,3.9.16]`; with 3.9.16 it passes; plain builds are unaffected on both. ## Note for reviewers Maven 3.9 prints mojo banners using the plugin's goal prefix (`deploy:3.1.4:deploy`) instead of its artifactId (`maven-deploy-plugin:3.1.4:deploy`). `flink-ci-tools`' `DeployParser` and `DependencyParser` match only the artifactId spelling, and no released `flink-ci-tools` carries the parser fix from FLINK-40459 (newest on Central is 2.3.0; this repo uses 2.2.1). On Maven 3.9 the checker therefore extracts 0 deployed modules, demotes every NOTICE entry to a TOLERATED "not bundled, but listed" warning, and still exits 0. Measured on this repo: ``` Maven 3.8.6 -> Extracted 4 modules that were deployed and 7 modules which bundle dependencies Maven 3.9.16 -> Extracted 0 modules that were deployed and 7 modules which bundle dependencies ``` Both exit 0. A companion change to `flink-connector-shared-utils` (`ci_utils`) normalises those banners and asserts a non-zero module count so a check that inspected nothing fails instead of passing. **That should be merged first** — until it is, CI here will be green with the NOTICE half of the license check not actually running. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): **no** - The public API: **no** - The serializers: **no** - The runtime per-record code paths: **no** - Anything that affects deployment or recovery: **no** - The S3 file system connector: **no** ## Documentation - Does this pull request introduce a new feature? **no** --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes (please specify the tool below) Generated-by: Claude Code 2.1.267 (Claude Opus 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
