dianfu commented on code in PR #29070:
URL: https://github.com/apache/flink/pull/29070#discussion_r3965043397


##########
flink-python/pyflink/dataframe/dataframe.py:
##########
@@ -560,6 +553,111 @@ def drop_duplicates(
     distinct = drop_duplicates
     unique = drop_duplicates
 
+    # ======================== Windowing ========================
+
+    @PublicEvolving()
+    def tumble(
+        self,
+        *,
+        on: Union[str, Expression],
+        size: Union["datetime.timedelta", Expression],
+    ) -> "DataFrame":
+        """
+        Assign rows to fixed-size, non-overlapping (tumbling) windows.
+
+        Appends ``window_start``, ``window_end`` and ``window_time`` and 
returns an ordinary
+        DataFrame.
+
+        :param on: An existing event-time or processing-time column.
+        :param size: Window length.
+        :return: A new DataFrame with the window columns appended.
+        :raises TypeError: If ``on`` or ``size`` has an unsupported type.

Review Comment:
   Could we add some examples in the API doc for these API?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to