slachiewicz commented on PR #289: URL: https://github.com/apache/flink-connector-kafka/pull/289#issuecomment-5600765578
@MartijnVisser Addressed all review items in `a9ec7c19` and updated the PR title and description: - Added component tag `[FLINK-40137][Connectors/Kafka]` to commit subject and PR title. - Updated commit message and PR description to reflect that the value is giving the gating state and its lifecycle an explicit name and structure. - Updated `ReaderRecoveryGate` class Javadoc to explain both recovery triggers (restore vs. partial failover re-registration with reported splits) and their respective gating conditions. - Added Javadoc note on `drainReportedSplits` explaining that state is cleared eagerly. - Added `testCompletingInitialRegistrationDoesNotReleaseGateWithPendingReportedSplits` in `ReaderRecoveryGateTest` testing the interaction between the restore flag and pending reported splits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
