ferenc-csaky commented on code in PR #29102:
URL: https://github.com/apache/flink/pull/29102#discussion_r3957747971
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/ptf/ToChangelogFunction.java:
##########
@@ -192,25 +195,41 @@ private static void validateProducesPartialDeletes(
}
}
+ /** Maintains compatibility with compiled plans created before {@code
include_op_column}. */
public void eval(
final Context ctx,
final RowData input,
@Nullable final ColumnList op,
@Nullable final MapData opMapping,
@Nullable final Boolean producesFullDeletes) {
+ eval(ctx, input, op, opMapping, producesFullDeletes, null);
+ }
+
+ public void eval(
+ final Context ctx,
+ final RowData input,
+ @Nullable final ColumnList op,
+ @Nullable final MapData opMapping,
+ @Nullable final Boolean producesFullDeletes,
+ @Nullable final Boolean includeOpColumn) {
final StringData opCode = opMap.get(input.getRowKind());
if (opCode == null) {
return;
}
- opRow.setField(0, opCode);
final RowData payload;
if (input.getRowKind() == RowKind.DELETE && !producesFullDelete) {
payload = buildPartialDeletePayload(input);
} else {
payload = projectedOutput.replaceRow(input);
}
- collect(output.replace(opRow, payload));
+
+ if (this.includeOpColumn) {
+ opRow.setField(0, opCode);
+ collect(output.replace(opRow, payload));
+ } else {
+ collect(payload);
Review Comment:
Thanks, I was too quick taking the shortcut here. :) Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
