vbhanuchander-lang commented on PR #28473:
URL: https://github.com/apache/flink/pull/28473#issuecomment-5583953509
@dianfu @snuyanzin thanks — looked at the review comments.
The production fix should stay as `"l".equals(args[0])`. Rewriting `l` to
`L` and
delegating to razorvine is not equivalent: Flink's override exists because
the
parent treats typecode `'l'` as `int[]`, and `'L'` is unsigned long, a
different
typecode. Same override Spark landed in SPARK-21327. The `==` path is dead
because pickle builds a fresh String (BINUNICODE), which is why the long[]
branch never ran.
Happy to leave the test-style nits (javadoc, `Integer.MAX_VALUE + 10L`,
`List` vs `ArrayList`, extra cases) to @jubins — they don't change the fix.
The one test that must stay is the `new String("l")` case, so we don't
accidentally lock in interned-literal equality again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
