spuru9 commented on code in PR #1206:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1206#discussion_r3951582152
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java:
##########
Review Comment:
minor: Now that isOperatorControlledKey is public, removeOperatorConfigs
still has its own inline copy of the exact same prefix check right next to it —
worth deduplicating since that's the stated point of the change.
```
@VisibleForTesting
protected static Configuration removeOperatorConfigs(Configuration
config) {
Configuration newConfig = new Configuration(config);
for (String key : config.keySet()) {
if (FlinkRuntimeConfigurationUtils.isOperatorControlledKey(key))
{
newConfig.removeKey(key);
}
}
return newConfig;
}
```
(Note: this makes the K8S_OP_CONF_PREFIX static import unused — remove that
line too.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
