gustavodemorais commented on code in PR #29041: URL: https://github.com/apache/flink/pull/29041#discussion_r3895187189
########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/UuidType.java: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.types.logical; + +import org.apache.flink.annotation.PublicEvolving; + +import java.util.Collections; +import java.util.List; +import java.util.Set; +import java.util.UUID; + +/** + * Data type of a universally unique identifier (UUID). + * + * <p>The type represents a 128-bit value stored as a fixed 16-byte big-endian sequence, following + * RFC 4122. + * + * <p>The serializable string representation of this type is {@code UUID}. + */ +@PublicEvolving +public final class UuidType extends LogicalType { + + private static final long serialVersionUID = 1L; + + private static final Set<String> INPUT_OUTPUT_CONVERSION = conversionSet(UUID.class.getName()); Review Comment: One last nit: this reads too complicated for what it actually does ``` private static final Set<String> INPUT_OUTPUT_CONVERSION = conversionSet(UUID.class.getName()); @Override public boolean supportsInputConversion(Class<?> clazz) { return INPUT_OUTPUT_CONVERSION.contains(clazz.getName()); } ``` Can we simplify it? One of the recent types (DescriptorType) does a similar thing ``` private static final Class<?> INPUT_OUTPUT_CONVERSION = UUID.class; @Override public boolean supportsInputConversion(Class<?> clazz) { return INPUT_OUTPUT_CONVERSION == clazz; } ... ``` Same for supportsOutputConversion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
