SEPURI-SAI-KRISHNA commented on code in PR #29004:
URL: https://github.com/apache/flink/pull/29004#discussion_r3892117351
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala:
##########
@@ -824,6 +824,12 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
testSqlApi("lpad('ab', 5, '')", "NULL")
testAllApis("äää".lpad(13, "12345"), "lpad('äää',13,'12345')",
"1234512345äää")
+
+ // supplementary-plane characters count as one character and must not be
split
+ testSqlApi("lpad('😀', 1, 'x')", "😀")
+ testSqlApi("lpad('😀', 3, 'x')", "xx😀")
+ testSqlApi("lpad('😀😀', 1, 'x')", "😀")
+ testSqlApi("lpad('a', 3, '😀')", "😀😀a")
Review Comment:
Moved to `ScalarFunctionsTest` next to the existing lpad/rpad tests,
`StringFunctionsITCase` reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
