davidradl commented on code in PR #29033:
URL: https://github.com/apache/flink/pull/29033#discussion_r3879735114
##########
flink-python/pyflink/dataframe/dataframe.py:
##########
@@ -542,6 +542,85 @@ def drop_duplicates(
distinct = drop_duplicates
unique = drop_duplicates
+ # ======================== Slicing ========================
+
+ @PublicEvolving()
+ def limit(self, n: int) -> "DataFrame":
+ """
+ Keep at most the first ``n`` rows.
+
+ This is a lazy transformation. Row order is deterministic only when
the underlying table
+ has an explicit ordering.
Review Comment:
I suggest explaining or referencing what lazy transformation means here.
Can we expose orderBy as well?
nit: I assume that changes to the underlying table content could make the
row order not deterministic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]