snuyanzin commented on code in PR #29010:
URL: https://github.com/apache/flink/pull/29010#discussion_r3872508643


##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/formats/raw/RawFormatSerializationSchema.java:
##########
@@ -220,6 +225,30 @@ public byte[] convert(RowData row) {
         };
     }
 
+    /**
+     * Creates a converter that renders the {@link Variant} as a JSON 
document. The result is
+     * value-lossless but not byte-lossless: whitespace and object key order 
are normalized.
+     */
+    private static SerializationRuntimeConverter createVariantConverter(final 
String charsetName) {
+        // this also checks the charsetName is valid
+        Charset.forName(charsetName);

Review Comment:
   same as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to