pltbkd commented on code in PR #938:
URL: https://github.com/apache/flink-agents/pull/938#discussion_r3855214322
##########
runtime/src/main/java/org/apache/flink/agents/runtime/operator/PythonBridgeManager.java:
##########
@@ -172,6 +172,7 @@ void open(
}
if (containPythonAction || mem0Configured) {
initPythonActionExecutor(agentPlan, jobIdentifier);
+ resourceCache.setPythonActionExecutor(pythonActionExecutor);
Review Comment:
You're right that this is the cross-language case the description defers.
The current assumption is that each language's resources are only consumed
within that language — cross-language sub-agent invocation involves coroutine
coordination between the two runtimes, which we've assessed as high complexity.
The plan is to route it through a same-language delegate (internal sub-agent)
so the coroutine boundary stays within one language; the final shape will be
refined when we get there.
For the guard condition, I'll widen it so the executor is initialized
whenever Python-owned resources exist, and make the "Python-owned" detection
consistent across all three check sites — it currently misses
PythonSerializableResourceProvider. I'll also fix the misleading checkState
message, and consolidate the duplicated "is this provider Python-owned?" checks
into one shared helper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
