cansuk99 commented on code in PR #922:
URL: https://github.com/apache/flink-agents/pull/922#discussion_r3838896090
##########
python/flink_agents/api/chat_models/chat_model.py:
##########
@@ -216,7 +216,10 @@ def _extract_reasoning(
reasoning_chunks.extend(m.strip() for m in matches if
m.strip())
cleaned = pat.sub("", cleaned)
- reasoning = "\n\n".join(reasoning_chunks) if reasoning_chunks else None
+ if not reasoning_chunks:
+ return content, None
Review Comment:
Yes,`return cleaned, None` works here, I have implemented it - thanks for
catching this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]