tamizhgeek commented on code in PR #255:
URL:
https://github.com/apache/flink-connector-aws/pull/255#discussion_r3821102997
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/reader/fanout/FanOutKinesisShardSplitReader.java:
##########
@@ -42,6 +42,12 @@
*/
@Internal
public class FanOutKinesisShardSplitReader extends KinesisShardSplitReaderBase
{
+
+ // See FanOutKinesisShardSubscription#maxRecoverableAttempts.
+ private static final int MAX_RECOVERABLE_SUBSCRIBE_ATTEMPTS = 100;
+ private static final Duration RECOVERABLE_SUBSCRIBE_BASE_BACKOFF =
Duration.ofMillis(500);
+ private static final Duration RECOVERABLE_SUBSCRIBE_MAX_BACKOFF =
Duration.ofSeconds(30);
+
Review Comment:
If these are constants (not configurable) why do we need to set them in here
instead of directly having it on the FanOutKinesisShardSubscription ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
