Shekharrajak commented on code in PR #28791:
URL: https://github.com/apache/flink/pull/28791#discussion_r3812088744
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java:
##########
@@ -64,6 +65,7 @@ public class ShowCreateUtil {
private static final DateTimeFormatter TIMESTAMP_FORMATTER =
DateTimeFormatter.ofPattern("uuuu-MM-dd HH:mm:ss");
private static final String PRINT_INDENT = " ";
+ private static final String CONNECTION_SECRET_REFERENCE_KEY =
"__flink.encrypted-secret-key__";
Review Comment:
Added comment
https://github.com/apache/flink/pull/28791/changes/d498c26a0fcd45c12053997d31a0c22ca32fa7fb
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java:
##########
@@ -349,6 +374,18 @@ static Optional<String>
extractComment(ResolvedCatalogModel model) {
: Optional.of(model.getComment());
}
+ static Optional<String> extractComment(CatalogConnection connection) {
+ return StringUtils.isEmpty(connection.getComment())
+ ? Optional.empty()
+ : Optional.of(connection.getComment());
+ }
+
+ static Map<String, String> withoutConnectionInternalOptions(Map<String,
String> options) {
+ return options.entrySet().stream()
+ .filter(entry ->
!CONNECTION_SECRET_REFERENCE_KEY.equals(entry.getKey()))
+ .collect(Collectors.toMap(Map.Entry::getKey,
Map.Entry::getValue));
+ }
Review Comment:
updated
https://github.com/apache/flink/pull/28791/changes/d498c26a0fcd45c12053997d31a0c22ca32fa7fb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
