gustavodemorais commented on code in PR #28991:
URL: https://github.com/apache/flink/pull/28991#discussion_r3806215745
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/JsonFunctionsITCase.java:
##########
@@ -1034,7 +1037,35 @@ private static List<TestSetSpec> parseJsonSpec() {
jsonString(call("TRY_PARSE_JSON", $("f1"))),
"JSON_STRING(TRY_PARSE_JSON(f1))",
null,
- STRING()));
+ STRING()),
+ // Regression test for FLINK-40410: PARSE_JSON(f0) (VARIANT)
precedes
+ // JSON_STRING(PARSE_JSON(f0)) (STRING) in a constant-folded
projection. VARIANT
+ // is excluded from folding in ExpressionReducer, like
ROW/ARRAY/MAP, and
+ // evaluated normally at runtime.
Review Comment:
Actually, I'd just drop the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
