weiqingy commented on issue #985:
URL: https://github.com/apache/flink-agents/issues/985#issuecomment-5323837354

   Thanks for the feedback @wenjin272.
   
   Option 2 also turns out to be the only workable one. The prompt fallback 
cannot render this schema either: `ReActAgent` builds its instruction prompt by 
rendering the schema (`python/flink_agents/api/agents/react_agent.py:130`), so 
an unrenderable model already raises there, before any connection is involved. 
There is no schema left to put in the prompt.
   
   One correction to my own issue while I am here: the Ollama 
`model_json_schema()` call I cited is in #981, not on `main`.
   
   I will open a PR and we can go through the implementation in review.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to