da-daken commented on code in PR #926:
URL: https://github.com/apache/flink-agents/pull/926#discussion_r3792072589
##########
runtime/src/main/java/org/apache/flink/agents/runtime/context/RunnerContextImpl.java:
##########
@@ -477,7 +599,7 @@ protected <T> Optional<T> tryGetCachedResult(
} else if (resultPayload != null) {
return Optional.of(OBJECT_MAPPER.readValue(resultPayload,
resultClass));
} else {
- return Optional.of(null);
+ return Optional.empty();
Review Comment:
This path will actually not be reached anymore. When switching from parallel
to serial, `matchNextOrClearSubsequentCallResult` already returns `null` for
slots that are in the pending state. However, to avoid introducing other
potential errors, I will keep this null pointer exception as is; we can fix it
later if any problems arise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
