auroflow commented on code in PR #28924:
URL: https://github.com/apache/flink/pull/28924#discussion_r3781333054
##########
flink-python/pyflink/table/expressions.py:
##########
@@ -115,10 +116,14 @@ def lit(v, data_type: DataType = None) -> Expression:
>>> tab.select(col("key"), lit("abc"))
"""
- if data_type is None:
- return _unary_op("lit", v)
- else:
- return _binary_op("lit", v, _to_java_data_type(data_type))
+ _j_literal_value = _to_java_literal_value(v, data_type)
Review Comment:
Yes, now _to_java_data_type() is called before _to_java_literal_value().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
