Zhuoxi2000 commented on PR #959:
URL: https://github.com/apache/flink-agents/pull/959#issuecomment-5223740058

   > Thanks for taking this on, and for covering the tool_use branch alongside 
the fixed one.
   > 
   > One thing that might be useful for the issue: the Java connector already 
attaches these three keys to every response, whatever the stop reason.
   > 
   > Fix and tests check out against main. Nothing further from me, and I'll 
leave the final call to the maintainers.
   
   Thanks for checking against main! Good catch on the Java side, confirmed 
that it preserves `model_name`, `promptTokens`, and `completionTokens` on every 
response path, so this fix brings Python back in line with Java. I’ve noted 
that on #946 as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to