raminqaf commented on code in PR #28850: URL: https://github.com/apache/flink/pull/28850#discussion_r3721333697
########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/codegen/JsonCodeGenHelper.java: ########## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.codegen; + +import org.apache.flink.table.planner.codegen.calls.BuiltInMethods; +import org.apache.flink.table.runtime.functions.SqlJsonUtils; +import org.apache.flink.table.types.logical.LogicalType; + +import scala.Option; +import scala.Tuple2; +import scala.collection.Seq; + +/** Utilities shared across the code generation of JSON functions. */ +public final class JsonCodeGenHelper { Review Comment: Are we planning to move or collect all the JsonCodeGen utils here? Besides I will rename it to JsonCodeGenUtils ########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/codegen/JsonCodeGenHelper.java: ########## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.codegen; + +import org.apache.flink.table.planner.codegen.calls.BuiltInMethods; +import org.apache.flink.table.runtime.functions.SqlJsonUtils; +import org.apache.flink.table.types.logical.LogicalType; + +import scala.Option; +import scala.Tuple2; +import scala.collection.Seq; + +/** Utilities shared across the code generation of JSON functions. */ +public final class JsonCodeGenHelper { + + private JsonCodeGenHelper() {} + + /** + * Generates {@code JSON_TYPE(jsonValue)} or {@code JSON_TYPE(jsonValue, path)}: the first + * argument is parsed into a {@link SqlJsonUtils.JsonValueContext} and the type flag is read off + * it (optionally at {@code path}), guarded so that a NULL argument yields a NULL result. + * + * <p>The parsed context is shared with the other JSON functions over the same input, so the + * input is parsed only once per record. + * + * @param ctx the code generator context + * @param returnType the result type of the call + * @param operands the generated operands: the JSON value, and optionally a path + * @return the generated expression for the call Review Comment: I would just remove these ```suggestion ``` ########## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlJsonUtils.java: ########## @@ -73,6 +73,7 @@ public class SqlJsonUtils { Pattern.compile( "^\\s*(?<mode>strict|lax)\\s+(?<spec>.+)$", Pattern.CASE_INSENSITIVE | Pattern.DOTALL | Pattern.MULTILINE); + Review Comment: nit remove -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
