rosemarYuan commented on code in PR #821:
URL: https://github.com/apache/flink-agents/pull/821#discussion_r3720578094
##########
docs/yaml-schema.json:
##########
@@ -35,6 +35,7 @@
},
"trigger_conditions": {
"items": {
+ "pattern": "\\S",
Review Comment:
Hi @wenjin272, thank you for the review. I fixed all four issues. Float
values now behave the same after a JSON round trip. The protobuf version and
NOTICE now match the final dist dependency tree. Quoted EventType.* values are
handled as event types. I also synced the development Skill YAML schema and
manifest, and added a test to prevent future drift. I grouped these changes
into four fixup commits. Could you please take another look? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
